Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store expansion pass #4068

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

sketch out store expansion pass

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

extract IRLiterals which are instruction arguments; this reduces
pressure on the stack scheduler
vyper/venom/passes/extract_literals.py Fixed Show fixed Hide fixed
vyper/venom/passes/store_expansion.py Fixed Show fixed Hide fixed
vyper/venom/passes/store_expansion.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (3371956) to head (adbf01c).
Report is 6 commits behind head on master.

Current head adbf01c differs from pull request most recent head 61ea577

Please upload reports for the commit 61ea577 to get more accurate results.

Files Patch % Lines
vyper/venom/passes/extract_literals.py 92.59% 1 Missing and 1 partial ⚠️
vyper/venom/passes/store_expansion.py 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4068      +/-   ##
==========================================
- Coverage   91.25%   88.75%   -2.50%     
==========================================
  Files         108      110       +2     
  Lines       15522    15582      +60     
  Branches     3410     3423      +13     
==========================================
- Hits        14164    13830     -334     
- Misses        926     1239     +313     
- Partials      432      513      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


insertion_idx = idx + 1

prev = var

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'prev' is unnecessary as it is
redefined
before this value is used.
inst.parent.insert_instruction(new_inst, insertion_idx)
insertion_idx += 1
use_inst.operands[i] = new_var
prev = new_var

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable prev is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant