-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store expansion pass #4068
base: master
Are you sure you want to change the base?
feat: store expansion pass #4068
Conversation
extract IRLiterals which are instruction arguments; this reduces pressure on the stack scheduler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4068 +/- ##
==========================================
- Coverage 91.25% 88.75% -2.50%
==========================================
Files 108 110 +2
Lines 15522 15582 +60
Branches 3410 3423 +13
==========================================
- Hits 14164 13830 -334
- Misses 926 1239 +313
- Partials 432 513 +81 ☔ View full report in Codecov by Sentry. |
|
||
insertion_idx = idx + 1 | ||
|
||
prev = var |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
redefined
inst.parent.insert_instruction(new_inst, insertion_idx) | ||
insertion_idx += 1 | ||
use_inst.operands[i] = new_var | ||
prev = new_var |
Check notice
Code scanning / CodeQL
Unused local variable Note
What I did
sketch out store expansion pass
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture