Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[ux]: improve an exports error message #3822

Conversation

charles-cooper
Copy link
Member

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.19%. Comparing base (391f3cc) to head (5615f1c).
Report is 1 commits behind head on master.

Files Patch % Lines
vyper/semantics/analysis/module.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
+ Coverage   85.18%   85.19%   +0.01%     
==========================================
  Files          92       92              
  Lines       13908    13908              
  Branches     3116     3116              
==========================================
+ Hits        11847    11849       +2     
+ Misses       1567     1565       -2     
  Partials      494      494              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title chore: improve an exports error message chore[ux]: improve an exports error message Feb 28, 2024
@charles-cooper charles-cooper merged commit 2df053f into vyperlang:master Feb 28, 2024
81 of 82 checks passed
@charles-cooper charles-cooper deleted the chore/improve-export-error-message branch February 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants