Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bb and bb_runtime output options #3700

Merged

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Dec 19, 2023

What I did

Currently running tests with experimental codegen was failing due to ir_dict output not being compatible.
This small patch rectifies all that and adds bb and bb_runtime as output options

How I did it

How to verify it

Commit message

Add bb and bb_runtime output options

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal self-assigned this Dec 19, 2023
@charles-cooper
Copy link
Member

i think i would rather have a new output type (bring back -f bb!) rather than changing the type of -f ir depending on the experimental mode

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ddfce52) 84.22% compared to head (8ea6d34) 84.15%.

❗ Current head 8ea6d34 differs from pull request most recent head e4b81b8. Consider uploading reports for the commit e4b81b8 to get more accurate results

Files Patch % Lines
vyper/compiler/output.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3700      +/-   ##
==========================================
- Coverage   84.22%   84.15%   -0.08%     
==========================================
  Files          92       92              
  Lines       13073    13038      -35     
  Branches     2916     2919       +3     
==========================================
- Hits        11011    10972      -39     
- Misses       1644     1646       +2     
- Partials      418      420       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harkal harkal force-pushed the fix/expcodegen_after_modules_merge branch from 01cec45 to f16d35a Compare December 31, 2023 18:25
@harkal harkal force-pushed the fix/expcodegen_after_modules_merge branch from a515980 to 88b4830 Compare January 3, 2024 09:54
@harkal harkal changed the title fix: disable ir_dict output type for venom feat: Add bb and bb_runtime output options Jan 3, 2024
@harkal harkal changed the title feat: Add bb and bb_runtime output options feat: Add bb and bb_runtime output options Jan 3, 2024
tests/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think maybe for test cleanliness we can introduce a new fixture output_formats

@pytest.fixture
def output_formats():
    return [k for k in compiler.OUTPUT_FORMATS.keys() if k not in ("bb", "bb_runtime")

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charles-cooper charles-cooper merged commit a1fd228 into vyperlang:master Jan 8, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/expcodegen_after_modules_merge branch January 8, 2024 16:13
@charles-cooper charles-cooper restored the fix/expcodegen_after_modules_merge branch January 8, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants