Repository navigation
chore: update published build to python 3.11 - #3385
Merged
charles-cooper merged 6 commits intoMay 7, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3385 +/- ##
==========================================
+ Coverage 88.88% 88.94% +0.05%
==========================================
Files 85 85
Lines 10708 10711 +3
Branches 2233 2441 +208
==========================================
+ Hits 9518 9527 +9
+ Misses 788 785 -3
+ Partials 402 399 -3 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
May 7, 2023
charles-cooper
changed the title
chore: update published build to python 3.11 and also update the rest of the CI to use 3.11. two reasons for doing this, even though 3.11 is a relatively new release: - python 3.11 is about 10% faster based on local benchmarks - universal2 images for darwin (on github actions) are only available for python builds starting with 3.11. cf. actions/setup-python#439 (comment)
charles-cooper
enabled auto-merge (squash)
May 7, 2023 14:39
charles-cooper
changed the title
charles-cooper
changed the title
charles-cooper
disabled auto-merge
May 7, 2023 14:40
charles-cooper
enabled auto-merge (squash)
May 7, 2023 14:41
charles-cooper
changed the title
fubuloubu
approved these changes
May 7, 2023
This reverts commit a59b9ab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
per title. builds are also with python 3.11 now too. two reasons:
_struct.cpython-310-darwin.sois not a fat binary actions/setup-python#439 (comment)How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture