Skip to content

Conversation

@charles-cooper
Copy link
Member

What I did

Pretty straightforward, also cleaned up some import statements

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #2595 (0115366) into master (ef1e6e4) will decrease coverage by 0.00%.
The diff coverage is 97.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
- Coverage   86.32%   86.31%   -0.01%     
==========================================
  Files          90       90              
  Lines        9291     9290       -1     
  Branches     2353     2353              
==========================================
- Hits         8020     8019       -1     
  Misses        789      789              
  Partials      482      482              
Impacted Files Coverage Δ
vyper/cli/vyper_lll.py 0.00% <0.00%> (ø)
vyper/cli/vyper_serve.py 0.00% <0.00%> (ø)
vyper/codegen/function_definitions/__init__.py 100.00% <ø> (ø)
vyper/codegen/function_definitions/utils.py 100.00% <ø> (ø)
vyper/codegen/memory_allocator.py 64.51% <ø> (ø)
vyper/codegen/types/__init__.py 100.00% <ø> (ø)
vyper/codegen/types/types.py 83.33% <ø> (ø)
vyper/cli/vyper_compile.py 74.16% <50.00%> (ø)
vyper/ast/signatures/function_signature.py 87.70% <100.00%> (ø)
vyper/ast/signatures/interface.py 81.48% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1e6e4...0115366. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 6, 2022

This pull request introduces 1 alert and fixes 1 when merging 9180758 into ef1e6e4 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for 'import *' may pollute namespace

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@charles-cooper charles-cooper enabled auto-merge (squash) January 7, 2022 01:44
@charles-cooper charles-cooper merged commit 44ec0c9 into vyperlang:master Jan 7, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 7, 2022

This pull request introduces 1 alert and fixes 1 when merging 0115366 into ef1e6e4 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for 'import *' may pollute namespace

@charles-cooper charles-cooper deleted the refactor_lll branch January 7, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants