-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AST end offsets and compressed source map #1580
AST end offsets and compressed source map #1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎇
@iamdefinitelyahuman I think the CLI switch is missing? |
@jacqueswww For now I've just included it as part of the output for If you'd like I can add another flag, |
I reckon that's fine for now, especially because of #1520 👍 |
What I did
pc_pos_map
How I did it
asttokens
libraryend_lineno
andend_col_offset
attributes to the final Vyper AST. (Attributes with these names are included in the standard ast library as of Python 3.8)LLLnode
objects, and add their values topc_pos_map
as returned byvyper.compile_lll.assembly_to_evm
pc_jump_map
toassembly_to_evm
output, in the format{'program counter': [io-]}
-i
indicates a jump instruction going into a private function,o
coming out of a private function,-
is an internal instruction such as a for loop or if / else statement.vyper.compiler.compress_source_map
: given source code,pc_pos_map
andpc_jump_map
, generates a compressed source map in the same format used bysolc
vyper.compiler.expand_source_map
: given a compressed source map string, expands it into a list of 4 item lists as[start, length, contract_id, jump]
pc_jump_map
andpc_pos_map_compressed
to compiler output given byvyper.compiler.get_source_map
How to verify it
Run the tests. I have added several new test cases around the jump map and compressed source map.
Description for the changelog
Cute Animal Picture