T7988: calculation for config-mode 'show' command #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2025
jestabro
changed the title
jestabro
force-pushed
the
show-config
branch
from
621cb0b to
f88baff
Compare
jestabro
force-pushed
the
show-config
branch
from
f88baff to
2ff84a3
Compare
We need finer grained access to rendering for the standard 'show' command to show line-by-line diff of running and session configs.
This was part of the hybrid adapter interim approach to integration with the legacy backend.
The comparison function used to order children in the diff function was unnecessarily general: maintain lexical-numeric ordering of nodes.
jestabro
force-pushed
the
show-config
branch
from
2ff84a3 to
411c132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Add calculation to produce the
showcommand diff, in the form familiar from legacy output, showing the unified diff of the running and proposed config under vyconf.This will require the companion PRs for vyconf and vyos-1x, the latter simply for normalization of function names and update of commit hashes.
Types of changes
Related Task(s)
Related PR(s)
Checklist: