-
Notifications
You must be signed in to change notification settings - Fork 394
vpp: T7972: Improve nat44 no-forwarding feature name and description in CLI
#4880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
|
👍 |
|
@sever-sever All change requests were addressed |
|
CI integration 👍 passed! Details
|
sever-sever
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my requests have been fulfilled.
Migrate NAT no-forwarding option to more clear CLI syntax/meaning
| <regex>(static-dynamic|static-bypass)</regex> | ||
| </constraint> | ||
| </properties> | ||
| <defaultValue>static-dynamic</defaultValue> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the static-bypass option to be the default one?
How I read this.
- Before: by default,
nat44 forwardingwas enabled (nono-forwardingin CLI). - After: by default,
nat44 forwardingis disabled, becausestatic-dynamicis a default value andenable_forwarding = config['processing_mode'] == 'static-bypass'
Am I missing something?
New CLI command for nat44 no-forwarding:
Change summary
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-documentation#1717
How to test / Smoketest result
Checklist: