T7731: Static ARP entries are missing after an interface status change

[natali-rs1985]

Change summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T7731

Related PR(s)

How to test / Smoketest result

set interfaces ethernet eth1 address 10.0.0.1/24
set protocols static arp interface eth1 address 10.0.0.2 mac 00:11:22:33:44:55
commit

vyos@vyos# sudo ip neighbor
10.0.0.2 dev eth1 lladdr 00:11:22:33:44:55 PERMANENT
10.20.40.1 dev eth2 lladdr 52:54:00:96:c3:5d STALE

Change interface status (VPP configuration requires interface reinitialization)

set vpp settings interface eth1 driver dpdk
commit

Before the fix ARP entry was missing

vyos@vyos# sudo ip neighbor
10.20.40.1 dev eth2 lladdr 52:54:00:96:c3:5d STALE

After the fix it's in place

vyos@vyos# sudo ip neighbor
10.0.0.2 dev eth1 lladdr 00:11:22:33:44:55 PERMANENT
10.20.40.1 dev eth2 lladdr 52:54:00:96:c3:5d STALE

vyos@vyos# /usr/libexec/vyos/tests/smoke/cli/test_vpp.py -k test_21_static_arp
test_21_static_arp (__main__.TestVPP.test_21_static_arp) ... ok

----------------------------------------------------------------------
Ran 1 test in 34.444s

OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[c-po]

Two more minor changes, rest looks good to me. Happy to approve after the changes were made.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) ❌ failed
• CLI Smoketests VPP 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• Config tests VPP 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed

[c-po]

Implementation looks sane. All requested changes got incorporated into this PR. Thanks!