Correctly handle linkage qualifiers for dpcpp device functions. (libo…

…cca#662)
vyast-softserveinc · Sep 12, 2023 · 4638408 · 4638408
1 parent a9e9ddd
commit 4638408
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/examples/cpp/30_device_function/addVectors.okl b/examples/cpp/30_device_function/addVectors.okl
@@ -1,4 +1,4 @@
-float add(const float* a,
+static float add(const float* a,
           int i,
           const float* b,
           int j) {

diff --git a/src/occa/internal/lang/modes/dpcpp.cpp b/src/occa/internal/lang/modes/dpcpp.cpp
@@ -257,13 +257,12 @@ namespace occa
             .forEach([&](statement_t *smnt)
                      {
                        functionDeclStatement &funcDeclSmnt = (functionDeclStatement &)*smnt;
-
-                       if (funcDeclSmnt.hasAttribute("kernel"))
-                       {
-                         return;
-                       }
+                       if (funcDeclSmnt.hasAttribute("kernel")) return;
 
                        vartype_t &vartype = funcDeclSmnt.function().returnType;
+                       if (vartype.has(occa::lang::static_)) return;
+
+                       // Only add SYCL_EXTERNAL if we have external linkage
                        vartype.qualifiers.addFirst(vartype.origin(), device);
                      });
       }