Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto wandb tag with benchmark.py #308

Merged
merged 6 commits into from
Nov 2, 2022
Merged

Auto wandb tag with benchmark.py #308

merged 6 commits into from
Nov 2, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Oct 31, 2022

Description

This PR aims to automatically add some version control tags to benchmark.py. It helps with #296 and #307 because the version control tags help us compare the performance of different codebase versions.

image

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 7:26PM (UTC)

@vwxyzjn vwxyzjn requested a review from kinalmehta October 31, 2022 20:38
Copy link
Collaborator

@kinalmehta kinalmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great addition for easy comparison and benchmarks.
Super cool work!!

LGTM.

@vwxyzjn vwxyzjn merged commit e23e4f9 into master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants