-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPO + JAX + EnvPool + Atari #227
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preliminary docs are available at https://cleanrl-git-jax-ppo-envpool-atari-vwxyzjn.vercel.app/rl-algorithms/ppo/#ppo_atari_envpool_xla_jaxpy. |
We got this message. See #227 (comment) ``` NotImplementedError: Got <class 'jaxlib.xla_extension.DeviceArray'>, but numpy array, torch tensor, or caffe2 blob name are expected. ```
Hi @yooceii @kinalmehta, I have addressed most of your concerns. Please let me know if additional tweaks are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the concerns seem to be addressed.
LGTM
Great Work!!
Description
Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.width=500
andheight=300
).