Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: LuaJIT #7

Closed
RHCPNG opened this issue Nov 22, 2020 · 4 comments
Closed

Request: LuaJIT #7

RHCPNG opened this issue Nov 22, 2020 · 4 comments

Comments

@RHCPNG
Copy link

RHCPNG commented Nov 22, 2020

Hi vwout,

I'm back with another request. This is very interesting with respect to performance improvement. Can you please take a look at this post and consider implementing LuaJIT?

https://smarthome.community/topic/179/luajit/29?_=1606034453370

Looks promising. Always looking to improve my setup

vwout added a commit that referenced this issue Dec 20, 2020
@vwout
Copy link
Owner

vwout commented Dec 20, 2020

Commit b1aef93 adds LuaJIT (2.1.0-beta3) to the OpenLuup Docker images.
It is not used by default in the loader script (yet) and also does not replace Lua5.1 because that would break existing installation with a volume for /etc/cmh-ludl/.

To start using LuaJIT, modify openLuup_reload_for_docker and changes the lines lua5.1 openLuup/init.lua $@ to luajit openLuup/init.lua $@

@RHCPNG
Copy link
Author

RHCPNG commented Dec 22, 2020

Thanks for this! Can I just do the configuration with my current container without breaking things?

@vwout
Copy link
Owner

vwout commented Dec 22, 2020

When you are using /etc/cmh-ludl as volume, your setting should be retained.
The file openLuup_reload_for_docker is in that volume, which means it is not changed or updated with a container update. To change it, you need to open a shell in the container. This can be done either before or after the update of the container since lua5.1 (non JIT) is also included.

Before changing the script, be sure to check that luajit indeed is available in the container. In case not (because your container updated failed), your container will result in a boot loop.

@RHCPNG
Copy link
Author

RHCPNG commented Dec 22, 2020

Thanks, I will try it soon!

@vwout vwout closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants