Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix comb-filter effect on oversampled dry/wet; Fix link-in-out knob positioning; Fix oversampled filter artefacts #100

Merged
merged 19 commits into from
Aug 20, 2023

Conversation

vvvar
Copy link
Owner

@vvvar vvvar commented Jul 30, 2023

  • Link-in-Out knob position is fixed
  • Now Dry/Wet could be used with any oversampling mode(fixed comb effect)
  • Fixed incorrect filter behaviour when they could filter using incorrect sample rate(oversample mode only)

@vvvar vvvar changed the title Fix link positioning Bugfix: Fix comb-filter effect on oversampled dry/wet; Fix link-in-out knob positioning; Fix oversampled filter artefacts Jul 30, 2023
@vvvar vvvar self-assigned this Jul 30, 2023
@vvvar vvvar added the Bug Something isn't working label Jul 30, 2023
@vvvar vvvar linked an issue Jul 30, 2023 that may be closed by this pull request
@vvvar
Copy link
Owner Author

vvvar commented Jul 30, 2023

Testet with white noise on all oversampling modes
fix-comb-filter-effect

@vvvar
Copy link
Owner Author

vvvar commented Jul 30, 2023

Explanation - since oversampling introduces delay it creates a comb filter effect. The solution is to move dry/wet right before/after clipping.
Warning - dry/wet remember dry signal before wave shaping, therefore input gain affects it.

@vvvar
Copy link
Owner Author

vvvar commented Aug 5, 2023

Found a way how to make dry/wet work on the whole processing line with respect to the oversampling latency. Now "dry" signal is unprocessed audio and "wet" is everything PeakEater does to the signal.

@vvvar vvvar merged commit a99b8db into master Aug 20, 2023
@vvvar vvvar deleted the fix_link_positioning branch August 20, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry/Wet
1 participant