Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/test update: Recommend FileLockSQLiteBucket for all usage with SQLite + multiprocessing #95

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

JWCook
Copy link
Contributor

@JWCook JWCook commented Feb 2, 2023

And remove test with SQLiteBucket and ProcessPoolExecutor.

Fixes #94

Since this only updates docs and a test, it probably doesn't need a patch release. I'll leave that up to you, though.

…ove test with SQLiteBucket and ProcessPoolExecutor
@JWCook JWCook force-pushed the fix-sqlitebucket-test branch from d0a10ca to 9edeb02 Compare February 2, 2023 03:06
@JWCook JWCook changed the title Doc/test update: Recommend FileLockSQLiteBucket for all multiprocessing usage Doc/test update: Recommend FileLockSQLiteBucket for all usage with SQLite + multiprocessing Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 98.24% // Head: 98.24% // No change to project coverage 👍

Coverage data is based on head (9edeb02) compared to base (103252c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files           8        8           
  Lines         399      399           
  Branches       36       36           
=======================================
  Hits          392      392           
  Misses          4        4           
  Partials        3        3           
Impacted Files Coverage Δ
pyrate_limiter/sqlite_bucket.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vutran1710 vutran1710 merged commit 046f2bc into vutran1710:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky failures in test_concurrency
2 participants