Fix redis expiration #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys stored in redis should expire and not persist more than the max duration of the rates provided. Addresses issue #74
patch version bump
AbstractClass maintained as before. maxinterval adopted only for redis class.
- use pipeline for multi-command execution
Codecov ReportBase: 98.15% // Head: 98.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 98.15% 98.17% +0.02%
==========================================
Files 7 7
Lines 379 384 +5
Branches 33 34 +1
==========================================
+ Hits 372 377 +5
Misses 4 4
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@pavinjosdev tests alright now. |
|
@vutran1710 Okay, great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor & Update PR #81 fixing #74