Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse structs #3

Merged
merged 2 commits into from
May 6, 2019
Merged

Reuse structs #3

merged 2 commits into from
May 6, 2019

Conversation

afady
Copy link
Contributor

@afady afady commented May 6, 2019

reuse AppInfo and UserData structs across Bare Metal and Server services.

@afady afady requested a review from ddymko May 6, 2019 12:49
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          22       22           
  Lines        2252     2252           
=======================================
  Hits         1614     1614           
  Misses        321      321           
  Partials      317      317
Impacted Files Coverage Δ
server.go 71.42% <100%> (ø) ⬆️
bare_metal_server.go 74.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0af5d6...5537999. Read the comment docs.

Copy link
Contributor

@ddymko ddymko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ddymko ddymko merged commit 25280d7 into vultr:master May 6, 2019
ddymko added a commit to mamclaughlin/govultr that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants