Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Vultr Managed Databases #238

Merged
merged 11 commits into from
Mar 17, 2023
Merged

Add support for Vultr Managed Databases #238

merged 11 commits into from
Mar 17, 2023

Conversation

christhemorse
Copy link
Contributor

@christhemorse christhemorse commented Mar 3, 2023 •
edited
Loading

Description

PR for adding Vultr Managed Database support to govultr.

@christhemorse christhemorse changed the title Add support for Vultr Managed Databases DRAFT Add support for Vultr Managed Databases Mar 3, 2023
@christhemorse christhemorse changed the title DRAFT Add support for Vultr Managed Databases DRAFT: Add support for Vultr Managed Databases Mar 3, 2023
@christhemorse christhemorse changed the title DRAFT: Add support for Vultr Managed Databases Add support for Vultr Managed Databases Mar 3, 2023
@christhemorse christhemorse changed the title Add support for Vultr Managed Databases Draft: Add support for Vultr Managed Databases Mar 3, 2023
@christhemorse christhemorse marked this pull request as ready for review March 13, 2023 18:35
@christhemorse christhemorse changed the title Draft: Add support for Vultr Managed Databases Add support for Vultr Managed Databases Mar 13, 2023
@optik-aper optik-aper self-requested a review March 13, 2023 20:25
@optik-aper optik-aper self-assigned this Mar 13, 2023
@optik-aper optik-aper added the enhancement New feature or request label Mar 13, 2023
nwcs-sh
nwcs-sh suggested changes Mar 15, 2023
View reviewed changes
Copy link

@nwcs-sh nwcs-sh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

  • Check err immediately after
  • Avoid "shadowing" vars, golangci-lint will warn you when this is done
  • Use factory NewX pattern when instantiating objects
  • Disable the keepalives otherwise the connection will be pooled, which we do not want

nwcs-sh
nwcs-sh previously approved these changes Mar 16, 2023
View reviewed changes
@nwcs-sh
Copy link

nwcs-sh commented Mar 16, 2023

I'll approve knowing that this is an old design pattern, but it really should be refactored at some point

@christhemorse christhemorse requested a review from nwcs-sh March 16, 2023 16:20
@happytreees happytreees merged commit eb60e01 into vultr:master Mar 17, 2023
@christhemorse christhemorse deleted the govultr-dbaas branch March 17, 2023 15:42
@optik-aper optik-aper mentioned this pull request Mar 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper left review comments

@nwcs-sh nwcs-sh nwcs-sh approved these changes

Assignees

@optik-aper optik-aper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christhemorse @nwcs-sh @optik-aper @happytreees