Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Update : adding disk_count #130

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Feb 10, 2021

Description

The field disk_count was added to all plans for instances and baremetal. This denotes how many disks are available with the plan

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added the enhancement New feature or request label Feb 10, 2021
@ddymko ddymko requested a review from mamclaughlin February 10, 2021 16:35
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #130 (c0512f7) into master (84c673b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          23       23           
  Lines        1169     1169           
=======================================
  Hits          643      643           
  Misses        264      264           
  Partials      262      262           
Impacted Files Coverage Δ
plans.go 53.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c673b...c0512f7. Read the comment docs.

@ddymko ddymko merged commit a3ffd0e into vultr:master Feb 10, 2021
@ddymko ddymko deleted the plans-update branch February 10, 2021 20:02
@ddymko ddymko mentioned this pull request Feb 11, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants