Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change(db): change Redis Architecture and reduce diff in processing between OSs in RDB part #145

Merged
merged 72 commits into from
Sep 14, 2021

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Aug 8, 2021

What did you implement:

Fixes #142

Redis Architecture is changed.
Other than Redis Architecture, the following changes have been made.
For amazon and oracle, the packages in AffectedPacks are now filtered by arch when searching with arch.
For redhat (redis only), it is necessary to filter by .module+el as well.
When searching for a package in suse(opensuse, opensuse.leap), the package is now searched in major.minor ver.

NOTE

In this PR, we are changing the architecture of Redis.

// delete all old key
$ redis-cli keys "OVAL#*" | xargs redis-cli del

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

$ make clean-integration && make build-integration
$ make fetch-rdb && make fetch-redis
$ make diff-server-redis // Expect: Diff will occur, but it is due to this change
$ make diff-server-rdb-redis // Expect: no diff

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

Not Found
@MaineK00n MaineK00n self-assigned this Aug 8, 2021
@MaineK00n MaineK00n changed the title [WIP] feat(redis): change Redis Architecture feat(redis): change Redis Architecture Aug 10, 2021
@MaineK00n MaineK00n changed the title breaking-change(db): change Redis Architecture and reduce diff in processing between OSs in RDB part [WIP] breaking-change(db): change Redis Architecture and reduce diff in processing between OSs in RDB part Aug 25, 2021
@MaineK00n MaineK00n changed the title [WIP] breaking-change(db): change Redis Architecture and reduce diff in processing between OSs in RDB part breaking-change(db): change Redis Architecture and reduce diff in processing between OSs in RDB part Sep 12, 2021
@MaineK00n MaineK00n requested a review from kotakanbe September 12, 2021 16:44
@kotakanbe kotakanbe merged commit 2851000 into vulsio:master Sep 14, 2021
kotakanbe added a commit to future-architect/vuls that referenced this pull request Sep 14, 2021
kotakanbe added a commit to future-architect/vuls that referenced this pull request Sep 14, 2021
kotakanbe added a commit to future-architect/vuls that referenced this pull request Sep 14, 2021
@MaineK00n MaineK00n deleted the change-redis-arch branch September 15, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants