Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2425 #2576

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Revert #2425 #2576

merged 1 commit into from
Oct 18, 2024

Conversation

marc0246
Copy link
Contributor

This reverts #2425. I was cooking something, but plans have changed and we're going with a new crate for the new command buffer and deprecating the old one, so it doesn't make sense to break code for no reason now.

Changelog:
Remove these lines:

### Breaking changes
Changes to command buffers:
- Merged `{Primary,Secondary}AutoCommandBuffer` into `CommandBuffer` and the corresponding `RecordingCommandBuffer::{primary,secondary}` into `new`.
- `RecordingCommandBuffer` no longer has a type parameter for the command buffer level.

@Rua
Copy link
Contributor

Rua commented Oct 18, 2024

Should RecordingCommandBuffer not be renamed back to AutoCommandBufferBuilder as well?

@marc0246
Copy link
Contributor Author

Does it have to be in this PR? This PR is reverting #2425.

@Rua
Copy link
Contributor

Rua commented Oct 18, 2024

No, I just wasn't sure if you were planning to do them in stages.

@Rua Rua merged commit 5749fef into vulkano-rs:master Oct 18, 2024
6 checks passed
@marc0246 marc0246 deleted the revert-2425 branch October 19, 2024 03:17
@marc0246 marc0246 mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants