Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite VertexDefinition #2487

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Mar 4, 2024

Changelog:

### Breaking changes
Changes to vertex input:
- The `VertexDefinition::definition` trait method now takes an `EntryPoint` instead of a `ShaderInterface`.
- `VertexMemberInfo` now has a `stride` member and its `offset` member now has the type `u32`.

Changes to shaders:
- `ShaderInterface` and subtypes are removed. `EntryPointInfo` no longer has `input_interface` and `output_interface` members.

### Additions
- `VertexDefinition` now fully supports 64-bit types and struct types in input/output interfaces.
- `VertexDefinition` now uses a placeholder name if a name is not present in the shader, instead of panicking.

@marc0246 marc0246 merged commit b190d6f into vulkano-rs:master Mar 4, 2024
5 checks passed
marc0246 added a commit that referenced this pull request Mar 4, 2024
@Rua Rua deleted the vertex-definition branch February 3, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants