Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo manifests #2377

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Fix Cargo manifests #2377

merged 2 commits into from
Oct 29, 2023

Conversation

marc0246
Copy link
Contributor

A couple fixes to the Cargo manifests of our public crates:

  • vulkano had both a macros and vulkano-macros feature, the latter of which is completely useless and can't be used. Now there's only macros so it's a bit less confusing hopefully.
  • Each crate's manifest links to its subdirectory in the repo, instead of the repo as a whole.
  • Each crate's manifest links to its own docs page, rather than vulkano's.
  • Each crate now has the readme linked.
  • Other miscellaneous improvements.

@Rua
Copy link
Contributor

Rua commented Oct 29, 2023

The new repository URLs are all deadlinks, so I think something went wrong there.

@marc0246
Copy link
Contributor Author

Oof, I don't know how I didn't see that.

@Rua Rua merged commit 1964ae7 into vulkano-rs:master Oct 29, 2023
3 checks passed
@marc0246 marc0246 deleted the cargo-manifests branch October 29, 2023 17:54
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Fix Cargo manifests

* Oopsie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants