Skip to content

Conversation

@sewe2000
Copy link
Member

Hello!
My team and I are working on our project with this library, but we've noticed that it doesn't implement the functionality we needed that is present in the original vulcan-api. So we created this PR to contribute our work back to this repo.

@sewe2000 sewe2000 changed the title Add missing functionality from original vulcan-api Add some missing functionality from original vulcan-api Feb 20, 2023
@Capure
Copy link
Collaborator

Capure commented Feb 21, 2023

Hi, thank you for the contribution.
I was gonna add these at some point but never got around to actually do it. You did some great work. Would you mind getting rid of that console.log tho? As soon as that's done I will get it merged.

@sewe2000
Copy link
Member Author

Ok, it's done.

@sewe2000
Copy link
Member Author

Hello, are you there?

@Capure Capure merged commit c437d45 into vulcan-api:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants