[VUFIND-1808] No fancy quote normalization

[damien-git]

See VUFIND-1808 - Do not strip fancy quotes

This change fixes issues with fancy quotes when they are part of the title and are included in a phrase (exact) query. Also, normalizing quotes does not seem useful in any way with the current Solr implementation.

TODO

• Add changelog note about changed behavior when merging

[demiankatz]

Thanks, @damien-git -- now the question is whether we should treat this as a bug fix for 11.0.1, or if it's a big enough change that we want to wait until 11.1. I'm personally inclined to lean toward 11.0.1 -- but maybe others will feel differently. I'll leave this open for a few days to collect comments; maybe we can discuss at next week's Community Call.

[damien-git]

@demiankatz Right, I was also wondering. It's a bug fix, but I can't entirely discard the possibility of it breaking something for someone...

[demiankatz]

I've put it on the agenda for next week's call so I don't forget to bring it up there!

[meganschanz]

Discussion in the community call: no immediate concerns raised, but we will wait a few more days to allow others to look at this more closely if desired. If no comments or issues are raised in a week we will plan to merge this for the 11.0.1 release as a bug fix.

[demiankatz]

Thanks for capturing the update, @meganschanz. I have added this to the 11.0.1 milestone so it is tracked, and I'll approve and merge it in a week if no objections are raised before then.

[demiankatz]

There has been no further discussion since the Community Call, which I will take as a lack of objections/concerns. Thanks, @damien-git, I'm merging this now!