fix(reactivity): correctly trigger content update if prop changes #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done testing, I added the test case in the demo which can be seen with the push of a button and typing in the editor I had to upgrade deps and tweak around because I couldn't get the demo to run with those old deps on my machine, it still cannot build the demo for prod because of the |
Tofandel
force-pushed
the
patch-1
branch
2 times, most recently
from
08be71b to
7abda7c
Compare
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using an intermediate value we can trigger the appropriate events only when the prop is externally modified
Fixes #188
It also now correctly trigger content:update if the content is truly different than the prop (as I had this problem and the content would just trigger update randomly even though the content was the same which would trigger a history stack push)