feat(VExpansionPanelTitle): add hover prop to disable hover effect#22725
Open
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Open
feat(VExpansionPanelTitle): add hover prop to disable hover effect#22725mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Conversation
Adds a boolean hover prop (default: true) to VExpansionPanelTitle that controls the hover overlay. When set to false a no-hover modifier class is added which forces the overlay opacity to zero. The prop is also forwarded from VExpansionPanels so that the whole panel group can be configured from a single place: <v-expansion-panels :hover="false"> Closes vuetifyjs#21615
Contributor
I can see the changes in the dedicated tab, no need to repeat those - better to leave PR description for information that is not clear upon inspecting the code (like motivation behind some less-obvious of the changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #21615
There was no built-in prop to disable the hover overlay effect on
v-expansion-panels; the only option was a CSS workaround:This PR adds a
hoverboolean prop (default:true) to bothVExpansionPanelTitleandVExpansionPanels.Usage
Changes
VExpansionPanelTitle.tsx— addshover: { type: Boolean, default: true }prop and applies thev-expansion-panel-title--no-hovermodifier class when disabledVExpansionPanel.sass— adds CSS rule that forces overlay opacity to0when the modifier class is presentVExpansionPanels.tsx— adds'hover'to thepick()list and toprovideDefaultsso the value cascades to all child panelsVExpansionPanelTitle.json— adds documentation for the new prop