Skip to content

fix(VDataTable): mobile view sort-by default to ascending #22426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prestonyford wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −2
Open

fix(VDataTable): mobile view sort-by default to ascending #22426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae357c
fix(VTreeView): mobile view sort-by default to ascending
prestonyford Dec 9, 2025
b7d7670
style(VTreeView): fix linter issues
prestonyford Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions packages/vuetify/src/components/VDataTable/VDataTableHeaders.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { LoaderSlot, makeLoaderProps, useLoader } from '@/composables/loader'
import { useLocale } from '@/composables/locale'

// Utilities
import { computed, mergeProps } from 'vue'
import { computed, mergeProps, ref, watch } from 'vue'
import { convertToUnit, genericComponent, propsFactory, useRender } from '@/util'

// Types
Expand Down Expand Up @@ -249,6 +249,30 @@ export const VDataTableHeaders = genericComponent<VDataTableHeadersSlots>()({
return columns.value.filter(column => column?.sortable && !props.disableSort)
})
const showSelectColumn = columns.value.find(column => column.key === 'data-table-select')
const chips = ref<any>([])

watch(() => chips.value, () => {
if (!chips.value) return
const c = [chips.value].flat()
for (const chip of c) {
if (chip.sortable && !isSorted(chip)) {
toggleSort(chip)
}
}
})

function onClickChip (item: any) {
if (item.raw?.sortable) {
toggleSort(item.raw)
}
if (!isSorted(item.raw)) {
if (Array.isArray(chips.value)) {
chips.value = chips.value.filter(chip => chip.value !== item.value)
} else {
chips.value = []
}
}
}

return (
<VDataTableColumn
Expand All @@ -261,6 +285,7 @@ export const VDataTableHeaders = genericComponent<VDataTableHeadersSlots>()({
>
<div class="v-data-table-header__content">
<VSelect
v-model={ chips.value }
chips
color={ props.color }
class="v-data-table__td-sort-select"
Expand All @@ -269,6 +294,7 @@ export const VDataTableHeaders = genericComponent<VDataTableHeadersSlots>()({
items={ displayItems.value }
label={ t('$vuetify.dataTable.sortBy') }
multiple={ props.multiSort }
returnObject
variant="underlined"
onClick:clear={ () => sortBy.value = [] }
>
Expand All @@ -284,7 +310,7 @@ export const VDataTableHeaders = genericComponent<VDataTableHeadersSlots>()({
) : undefined,
chip: props => (
<VChip
onClick={ props.item.raw?.sortable ? () => toggleSort(props.item.raw) : undefined }
onClick={ () => onClickChip(props.item) }
onMousedown={ (e: MouseEvent) => {
e.preventDefault()
e.stopPropagation()
Expand Down