-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(VDatePicker): restore weekday-format
#21290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da0a08c
to
f2e2230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to operate under the idea that other libraries aren't going to update and support this in the future.
f2e2230
to
32e4eac
Compare
Devs can extend adapters to force particular weekday format or make it support new arguments by copy/pasting from the date-io PR linked above. |
Is this something worth putting into an alert in the docs? |
Alert.. not really. More like a full blog post to cover differences & limitations. For now we have the disclaimer at the end of the prop description in API docs and I feel it is fine. People are asking for help with their specific adapters from time to time, so I guess we'll see their voices on Discord. You could touch on it in v3.8.6 announcement with something like "week format supported by default date adapter, see [issueID] for more details" IMO, getting built-in adapter better (and extendable: #21252) makes it easier for devs to achieve expected i18n goals without having to use 3rd party libraries. |
Moved to dev |
Description
weekdayFormat
existed in v2, but was not yet re-implemented.Note: It is going to be ignored by custom date adapters until those packages get updated by community.
date-fns
is already printing withEEEEEE
which equals to Intl'sshort
dd
hardcoded - i.e.narrow
Intl
withshort
hardcodedMarkup: