feat(styles): cut down CSS reset #20960
Open
+89
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelWD
force-pushed
the
feat/minimal-reset
branch
from
7bce4e9 to
c18c3ef
Compare
Member
Author
|
It looks like the only component this actually affected was VField, everything else still looks identical. |
J-Sek
reviewed
Jun 12, 2025
|
|
||
| * { | ||
| padding: 0; /* Reset `padding` and `margin` of all elements */ | ||
| margin: 0; |
Contributor
There was a problem hiding this comment.
This one maybe risky. I just toggled it off on my website and some things moved (<body> and <hr> were the most obvious). Tested on Brave.
Contributor
There was a problem hiding this comment.
VDivider.sass needs margin-block: 0, while the body might need to replace * here.. at least to get rid of the margin.
Member
Author
|
I think typography can be separate, maybe bring back the pre-0.17 styles as an optional import after #22396? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
90% of this is for ancient browsers and the rest can be done in component styles instead of affecting the entire page.
closes #17633