Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDialog): remove aria-expanded from activator #20414

Merged

Conversation

paul-thebaud
Copy link
Contributor

@paul-thebaud paul-thebaud commented Sep 2, 2024

Description

Remove useless aria-expanded attribute on dialog activators to follow WAI-ARIA recommandations.

When focusing a dialog activator, dialog will never already be expanded, so this information is useless and will pollute screen readers users.

Markup:

<template>
<v-app>
  <v-container>
    <v-dialog>
      <template #activator={ props }>
        <v-btn v-bind="props">Open</v-btn>
      </template> 
    </v-dialog>
  </v-container>
</v-app>
</template>

@KaelWD KaelWD changed the title fix(a11y): remove useless aria-expanded attribute on dialogs activator fix(VDialog): remove aria-expanded from activator Sep 3, 2024
@KaelWD KaelWD merged commit 1c40ed4 into vuetifyjs:master Sep 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants