Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): do not call closeParents() when clickoutside is inside parent itself #19239

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

yuwu9145
Copy link
Member

fixes #17004
fixes #19138

Description

Markup:

<template>
  <v-app>
    <v-main>
      <v-menu :close-on-content-click="false">
        <template #activator="{ props }">
          <v-btn v-bind="props">Open</v-btn>
        </template>
        <v-sheet class="pa-4">
          <div class="d-flex">
            <v-menu>
              <template #activator="{ props }">
                <v-btn style="display: block" v-bind="props">Sub menu</v-btn>
              </template>
              <v-sheet class="pa-4"> Click back in the input</v-sheet>
            </v-menu>
            <v-text-field style="width: 400px"></v-text-field>
          </div>
        </v-sheet>
      </v-menu>
    </v-main>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const msg = ref('Hello World!')
</script>

@yuwu9145 yuwu9145 marked this pull request as ready for review February 18, 2024 03:48
@yuwu9145 yuwu9145 changed the title fix(VMenu): do not call closeParents() when clickoutside is inside parent fix(VMenu): do not call closeParents() when clickoutside is inside its immediate parent Feb 18, 2024
@yuwu9145 yuwu9145 marked this pull request as draft February 18, 2024 04:13
@yuwu9145 yuwu9145 changed the title fix(VMenu): do not call closeParents() when clickoutside is inside its immediate parent fix(VMenu): do not call closeParents() when clickoutside is inside parent itself Feb 18, 2024
@yuwu9145 yuwu9145 marked this pull request as ready for review February 18, 2024 07:43
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VMenu VMenu labels Feb 21, 2024
@johnleider johnleider added this to the v3.5.x milestone Feb 21, 2024
@johnleider johnleider merged commit 5c88603 into master Feb 21, 2024
17 of 18 checks passed
@johnleider johnleider deleted the fix-19138 branch February 21, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants