Skip to content

fix(VSystemBar): reserve space for hidden scrollbar from VOverlay #16734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaelWD merged 1 commit into from
Feb 22, 2023
Merged

fix(VSystemBar): reserve space for hidden scrollbar from VOverlay #16734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/docs/src/components/app/V2Banner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<template>
<v-system-bar
v-if="showBanner"
class="px-4 py-1 "
color="#e7f0f6"
height="52"
>
<div class="text-blue-darken-3 text-start">
<div class="text-blue-darken-3 text-start ms-4">
<div class="text-caption">
You are currently viewing the documentation for <strong>Vuetify 3</strong>
</div>
Expand All @@ -25,7 +24,7 @@
</v-btn>

<v-btn
class="ms-6 me-2"
class="ms-6 me-6"
density="comfortable"
size="small"
icon="$clear"
Expand Down
6 changes: 5 additions & 1 deletion packages/vuetify/src/components/VSystemBar/VSystemBar.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
height: $system-bar-height
justify-content: $system-bar-justify-content
max-width: 100%
padding: $system-bar-padding
padding-inline-start: $system-bar-padding-x
padding-inline-end: $system-bar-padding-x
position: relative
text-align: $system-bar-text-align
width: 100%
Expand All @@ -26,3 +27,6 @@

&--window
height: $system-bar-window-height

&:not(.v-system-bar--absolute)
padding-inline-end: calc(var(--v-scrollbar-offset) + #{$system-bar-padding-x})
5 changes: 4 additions & 1 deletion packages/vuetify/src/components/VSystemBar/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ $system-bar-justify-content: flex-end !default;
$system-bar-letter-spacing: tools.map-deep-get(settings.$typography, 'caption', 'letter-spacing') !default;
$system-bar-lights-out-background: rgba(var(--v-theme-background), 0.7) !default;
$system-bar-line-height: tools.map-deep-get(settings.$typography, 'caption', 'line-height') !default;
$system-bar-padding: 0 8px !default;
$system-bar-padding-x: 8px !default;
$system-bar-positions: absolute fixed !default;
$system-bar-text-align: end !default;
$system-bar-text-transform: tools.map-deep-get(settings.$typography, 'caption', 'text-transform') !default;
Expand All @@ -35,3 +35,6 @@ $system-bar-typography: (
$system-bar-line-height,
$system-bar-text-transform
);

// Deprecated
$system-bar-padding: 0 8px !default;