This repository was archived by the owner on May 8, 2025. It is now read-only.
Removed deprecated null-loader dependency #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahKotyluk
approved these changes
Jun 3, 2021
|
Did you test this? Cause I didn't |
|
Yes, this was tested and it works fine. I merged it into dev, so it will be out in the next release. Looking to have a webpack 5 upgrade by then as well. Thank you for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: absolutely not tested, not familiar with chain-webpack, etc.
This should fix: #254
Relevant: #152
The chain webpack types don't seem to thing that an alias can be false, it appears that they are not up to date with webpack on this: https://webpack.js.org/configuration/resolve/#resolvealias
I thought I'd give it a try, but this is a bit out of my league