Skip to content

Conversation

akbarkz
Copy link
Collaborator

@akbarkz akbarkz commented Oct 19, 2018

Related issues

#1812

Short description and why it's useful

The Mailer module has been refactored to comply with the latest module requirements. Also sendEmail method has been generalized to send any kind of emails. Docs for the module are also provided.

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and curently important rules acceptance

@akbarkz akbarkz requested a review from filrak October 19, 2018 19:27
@filrak
Copy link
Collaborator

filrak commented Oct 20, 2018

Perfect example of module! Thanks @akbarik

@filrak
Copy link
Collaborator

filrak commented Oct 20, 2018

Do you want to do some additional work? Otherwise let's merge it to develop

@akbarkz
Copy link
Collaborator Author

akbarkz commented Oct 20, 2018

Do you want to do some additional work? Otherwise let's merge it to develop

No, I didn't plan to do something else with that :)

@filrak
Copy link
Collaborator

filrak commented Oct 20, 2018

I'll merge then. Thank you @akbarik !. Maybe now you can try to make Notification and user module (for auth and user data)? We want to stay abckward compatible even if we change APIs with strangler pattern. You can see examples of porting new API to old components in core/components -> Microcart component

@filrak filrak merged commit 6b96f17 into vuestorefront:develop Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants