Improve disabling full-button #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
approved these changes
Oct 12, 2018
|
Thanks for fixig it! Please send the PR's against "develop" branch. I've changed the base so no problem |
|
OK sure, sorry about that. Thought that features goes into develop and fixes to master. Will remember that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#1851
Short description and why it's useful
Improve forms validation.
Screenshots of visual changes before/after (if there are any)
Reproduction steps from issue are no longer submitting step/form.
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
Same tests fails as on master, these changes are irrelevant to them.
Upgrade Notes and Changelog
Contribution and currently important rules acceptance