Skip to content

Conversation

Aylay
Copy link
Contributor

@Aylay Aylay commented Jul 25, 2018

Ref to the issue #1454

Replace @textarea="$emit('textarea', $event.target.value)"By@input="$emit('input', $event.target.value)"Change insrc/themes/default/components/core/blocks/Form/BaseTextarea.vue`

@pkarw
Copy link
Collaborator

pkarw commented Jul 27, 2018

I'm not sur why did You change the 'input' to 'textarea' in here?

@Aylay
Copy link
Contributor Author

Aylay commented Jul 27, 2018

@pkarw Ref to the issue #1454

When the textarea field is filled, the textarea label doesn't stay on top of the field.
By changing @textarea in @input, the problem was solved

@pkarw
Copy link
Collaborator

pkarw commented Jul 30, 2018

OK, makes sense

@pkarw
Copy link
Collaborator

pkarw commented Jul 30, 2018

Please fix the es-lint issues before I'll merge it in:
https://travis-ci.org/DivanteLtd/vue-storefront/jobs/407940838

@Aylay
Copy link
Contributor Author

Aylay commented Jul 30, 2018

@pkarw I don't understand because I changed one file only : BaseTextarea.vue
How is it possible that there is a problem on another files ?

@Aylay
Copy link
Contributor Author

Aylay commented Jul 30, 2018

@pkarw maybe this PR : #1453

@Aekal
Copy link
Collaborator

Aekal commented Jul 30, 2018

@Aylay It looks like your PR is based on develop with eslint error, I fixed it last time. Try to merge latest develop to your branch and it should be fine

@Aylay
Copy link
Contributor Author

Aylay commented Jul 30, 2018

ok wait for it :)

@pkarw pkarw merged commit 4cf66d8 into vuestorefront:develop Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants