Skip to content

Conversation

sudo-at-night
Copy link
Contributor

I had some time so I thought I'd add a test for comparing products.

cy.setCookie('shop/claims/onboardingAccepted', 'test')
indexedDB.deleteDatabase('shop')
cy.clearLocalStorage()
cy.get(':nth-child(1) > .product > .no-underline > .product-image > img').click()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use css selector like this, it's very easy to break this test just by changing one class...
You can check my issue, I also did a lot of refactoring similar code in last PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made in cbdfafb

@pkarw pkarw merged commit 277d70f into vuestorefront:develop Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants