This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Added: Functionality to change the theme by modifying the colours, fonts and other CSS properties in one place #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts and other CSS properties in one place Added theme.scss file which contains variables and CSS property for the elements, which can be modified here to see the change globally. Included this file in the main.scss to override the SFUI and component's SCSS
|
I think we can also add a variable here to manage surface colors globally, this would make it easier to change the background color of the entire website quickly if someone doesn't want to use plain white. Thoughts? |
|
Additional things that are managed globally and may vary from brand to brand:
|
|
Also what about z-index groups? making it easy to manage z-index consistency for elements through out the app. |
|
Yes, we can add variables and properties for :
The current implementation can be consider as a phase 1 and after it get merge we can again work on giving the above functionalities. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #597
Short Description and Why It's Useful
Added theme.scss file which contains variables and CSS property for the elements, which can be modified here to see the change globally.
Included this file in the main.scss to override the SFUI and component's SCSS
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance