Improved: code to display the filter count on initial load (#554)

[ymaheshwari1]

Related Issues

#554

Closes #554

Short Description and Why It's Useful

The changes will help in displaying the filter count on the initial load of category page.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[ymaheshwari1]

There are two solutions for the issue:

1. call the composeInitialPageState in beforeRouteEnter hook. (57cb6cd)
2. move the subscribeAction logic to asyncData and then using global variables to access the filter count. (b854467)

[Fifciu]

Using global variables is not a good idea. It might cause race conditions in concurrent requests.

[ymaheshwari1]

@Fifciu
The other solution can be to call the composeInitialPageState in the beforeRouteEnter hook. You can see the solution in this commit: 57cb6cd

Also, another thing that I can think of is to maintain a state for storing the aggregations and then using that state in our component, and thus we also not need to subscribe to the action.

[ymaheshwari1]

@Fifciu I have updated the solution to make use of state and getter to use the aggregations, please review.
vuestorefront/vue-storefront#5392

[CLAassistant]

All committers have signed the CLA.

[Fifciu]

Please add Array.isArray(this.getAggregations[aggregation].buckets) check too

[ymaheshwari1]

Added the check for the aggregations array

[AishwaryShrivastav]

@Fifciu can you look into this also, changes looks good to me

[Fifciu]

Are you sure about this part? Have you test it manually?

[ymaheshwari1]

Yes, I have tested it. Actually, on the initial load of the category page, only two specific actions are getting subscribed so, I think this part is of no use.