Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Offline : Product Image is displayed twice on the Product page in offline mode #498

Closed
1 of 2 tasks
ymaheshwari1 opened this issue Sep 26, 2020 · 2 comments · Fixed by #507
Closed
1 of 2 tasks

Offline : Product Image is displayed twice on the Product page in offline mode #498

ymaheshwari1 opened this issue Sep 26, 2020 · 2 comments · Fixed by #507
Assignees
@ymaheshwari1
Labels
bug Something isn't working

Comments

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Sep 26, 2020 •
edited
Loading

Current behavior

The image of the product is duplicated in offline mode. There are two components used in m-product-gallery, SfImage and SfGallery. The SfImage component is rendered in offline mode and SfGallery is rendered in both the online and offline mode

Expected behavior

Only one of there needs to be rendered in offline mode.

Steps to reproduce the issue

  • Go to Product Page for any product
  • Change your network to offline
  • See the duplicated image

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

Screenshot
image
@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Sep 26, 2020
@ymaheshwari1
Copy link
Contributor Author

I want to work on it.

@Fifciu
Copy link
Collaborator

Fifciu commented Sep 30, 2020 •
edited
Loading

Awesome! Go for it @ymaheshwari1

ymaheshwari1 added a commit to hotwax/vsf-capybara that referenced this issue Oct 1, 2020
@ymaheshwari1
Fixed the code to remove the duplicated image issue in offline mode o…
7766879 
…n the product page (vuestorefront#498)
@ymaheshwari1 ymaheshwari1 mentioned this issue Oct 1, 2020
Merged
1 task
@ymaheshwari1 ymaheshwari1 changed the title Product Image is displayed twice on the Product page in offline mode Offline : Product Image is displayed twice on the Product page in offline mode Oct 12, 2020
ymaheshwari1 added a commit to hotwax/vsf-capybara that referenced this issue Dec 8, 2020
@ymaheshwari1
Merge branch 'develop' into vuestorefront#498/product-image-displayed…
231af77 
…-twice
Fifciu added a commit that referenced this issue Dec 8, 2020
@Fifciu
Merge pull request #507 from hotwax/#498/product-image-displayed-twice
5b903d3 
Fixed the code to remove the duplicated image issue in offline mode on the product page (#498)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ymaheshwari1 ymaheshwari1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Fifciu @ymaheshwari1