-
Notifications
You must be signed in to change notification settings - Fork 4
VL-280_UKey-component_Vitalii-Dudnik #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 1
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (keys.value.length === 0) return ""; | ||
| if (keys.value.length === 1) return getDisplayValue(keys.value[0]); | ||
|
|
||
| return keys.value.map(getDisplayValue).join(" + "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slot value format differs from default rendered output
Low Severity
The slot binding value differs from what the default slot content renders for keyboard shortcuts. The displayValue computed property joins keys with " + " (with spaces), producing "⌘ + K", while the default template rendering places keys adjacent to <span>+</span> without spaces, producing "⌘+K". Users overriding the slot and rendering {{ value }} will see different output than the default behavior.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect suggestion.
<span>+</span> is rendered with spaces because of parent's gap.
https://ilevel.atlassian.net/jira/software/c/projects/VL/boards/11?selectedIssue=VL-280
Note
Adds a new keyboard key display component.
UKey(ui.text-key/UKey.vue) renders single keys and" + "-joined shortcuts, mapping common names to symbols viaKEY_SYMBOLSvariant(solid|outlined|subtle|soft),size(sm|md|lg), andcolor(design system colors); exposeskeyRefand supports slot overridecomponents.ts,components.d.ts, and component map updated inconstants.jsui.text-key/storybook/stories.ts) and unit tests (ui.text-key/tests/UKey.test.ts) addedconfig.ts,constants.ts,types.tsWritten by Cursor Bugbot for commit a4d216c. This will update automatically on new commits. Configure here.