Skip to content

docs: update vitepress #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2021
Merged

docs: update vitepress #2070

merged 2 commits into from
Oct 15, 2021

Conversation

Alanscut
Copy link
Contributor

Based on #2049, update vitepress to 0.20.0, closing #2045.

@Alanscut Alanscut mentioned this pull request Oct 13, 2021
Closed
@Alanscut
Copy link
Contributor Author

That's strange, yarn docs:build success in my win10 and mac, but failed in the Netlify CI.....

@Alanscut
Copy link
Contributor Author

Hi @kiaking , the reason why netlify deploy failed is that node version is not compatible with vitepress 0.20.0, so

That's strange, yarn docs:build success in my win10 and mac, but failed in the Netlify CI.....

Never mind.... the node version of netlify is set to v12.18.0, which is not compatible with vitepress 0.20, so I upgrade vitepress to 0.19

@kiaking
Copy link
Member

kiaking commented Oct 14, 2021

@Alanscut I've updated node version to 16 in Netlify. Can you try again with 0.20? 🙏

@kiaking kiaking added 4.x documentation Improvements or additions to documentation labels Oct 14, 2021
@Alanscut
Copy link
Contributor Author

Alanscut commented Oct 14, 2021 •
edited
Loading

@Alanscut I've updated node version to 16 in Netlify. Can you try again with 0.20? 🙏

it's still v12.18.0....
image

I set the node version successfully according to https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript
image

@kiaking
Copy link
Member

kiaking commented Oct 14, 2021

Whaaaat... yeah I did change that part... let me check again.

@kiaking
Copy link
Member

kiaking commented Oct 14, 2021

OK I've changed Node to 14 and seems like success!

@kiaking kiaking merged commit d05b8cf into vuejs:4.0 Oct 15, 2021
@kiaking kiaking mentioned this pull request Oct 15, 2021
Closed
@Alanscut Alanscut deleted the fix-2045 branch October 15, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.x documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alanscut @kiaking