Skip to content

fix: function 'unregister', someplace maybe inaccurate #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: function 'unregister', someplace maybe inaccurate #1426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dbbb97
Update module-collection.js
zwwill Oct 17, 2018
2a65006
Merge pull request #1 from zwwill/zwwill-patch-1
zwwill Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/module/module-collection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class ModuleCollection {
unregister (path) {
const parent = this.get(path.slice(0, -1))
const key = path[path.length - 1]
if (!parent.getChild(key).runtime) return
if (!parent.getChild(key) || !parent.getChild(key).runtime) return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer assertion rather than silently ignoring when the specified module does not exist. Can we change the implementation to that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, maybe you can do it better latter


parent.removeChild(key)
}
Expand Down