Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack absolute output path #886

Closed
wants to merge 2 commits into from
Closed

Conversation

ekoeryanto
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)
image

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't use windows, so could you log the before/after resolving result so that I can know whether I can approve it?

BTW, I think using upath shouldn't take errors in windows.

@ekoeryanto
Copy link
Contributor Author

ekoeryanto commented Sep 29, 2018

@ulivz, so we need appveyor here.
here the log from my forked vuepress
before:
https://ci.appveyor.com/project/ekoeryanto/vuepress/build/job/w159tutdupa997nv
after:
https://ci.appveyor.com/project/ekoeryanto/vuepress/build/job/ll6oiqa4lk52y48x

as seen on the 'after' log line 49 and 50 I think the main issue is upath

@mAKEkr
Copy link
Contributor

mAKEkr commented Sep 30, 2018

@ulivz upath is problem on webpack path detection.
webpack/webpack#66

@ekoeryanto
Copy link
Contributor Author

@ulivz I think this is an urgent issue for windows users.
I'm afraid we need to revert 19e73d7 for safety reason

@meteorlxy
Copy link
Member

BTW, I suggest to use exact version requirement for alpha/beta releases, so we can revert to the exact version quickly.

i.e.

  "dependencies": {
    "@vuepress/cli": "^1.0.0-alpha.5",  // ^1.0.0-alpha.5 => 1.0.0-alpha.5
    "@vuepress/core": "^1.0.0-alpha.5",  // ^1.0.0-alpha.5 => 1.0.0-alpha.5
    "@vuepress/theme-default": "^1.0.0-alpha.5"  // ^1.0.0-alpha.5 => 1.0.0-alpha.5
  },

@ekoeryanto
Copy link
Contributor Author

It is fixed by d89f766

but after I reread the source, I think the better place to fix the issue is here

Sorry 😄

@ekoeryanto ekoeryanto closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants