-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webpack absolute output path #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't use windows, so could you log the before/after resolving result so that I can know whether I can approve it?
BTW, I think using upath
shouldn't take errors in windows.
@ulivz, so we need appveyor here. as seen on the 'after' log line 49 and 50 I think the main issue is |
@ulivz upath is problem on webpack path detection. |
BTW, I suggest to use exact version requirement for alpha/beta releases, so we can revert to the exact version quickly. i.e. "dependencies": {
"@vuepress/cli": "^1.0.0-alpha.5", // ^1.0.0-alpha.5 => 1.0.0-alpha.5
"@vuepress/core": "^1.0.0-alpha.5", // ^1.0.0-alpha.5 => 1.0.0-alpha.5
"@vuepress/theme-default": "^1.0.0-alpha.5" // ^1.0.0-alpha.5 => 1.0.0-alpha.5
}, |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: