-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refine group (fix#287) #669
Conversation
9873c5f
to
94bb32f
Compare
Test demo urls:
If you want to build the demo from scratch:
|
94bb32f
to
a297e13
Compare
0c3bc3a
to
cf1e6fc
Compare
a297e13
to
33b96ba
Compare
What does this mean / do?
|
@davestewart Right now, when you open a group, other groups will be closed automatically. With |
Looking forward for this, need any help? |
33b96ba
to
f1e0ec5
Compare
Rebased from master. Should I wait and rebase again when #815 is done? |
bd69d41
to
903138e
Compare
3f79224
to
fb05066
Compare
f1e0ec5
to
d2ceb05
Compare
- isolate a group's open status with `isolated: true` - config a isolated group's initial open status with `initialIsolatedOpen: true` - config a group's sidebarDepth with `sidebarDepth: 2` - nested sidebar groups
d2ceb05
to
24fea8a
Compare
Rebased on top of master. |
@@ -329,7 +335,7 @@ module.exports = { | |||
``` | |||
|
|||
::: warning Note | |||
Unlike the [built-in search](#built-in-search) engine which works out of the box, [Algolia DocSearch](https://community.algolia.com/docsearch/) requires you to submit your site to them for indexing before it starts working. | |||
Unlike the [built-in search](#built-in-search) engine which works out of the box, [Algolia DocSearch](https://community.algolia.com/docsearch/) requires you to submit your site to them for indexing before it starts working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is probably not relevant for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I have config my IDE to trim trailing whitespace. Should I add the whitespace back?
6c3127f
to
71574f2
Compare
316e022
to
1284944
Compare
Thanks for the great work, but it's not recommended to bundle two many features in a PR. I just create a PR containing following
For Let's move #1257 to continue. |
Summary
isolated: true
initialIsolatedOpen: true
sidebarDepth: 2
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
os: Mac High Sierra 10.13.6
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: