Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: theme-related pages #313

Closed
wants to merge 3 commits into from
Closed

Conversation

oott123
Copy link

@oott123 oott123 commented May 1, 2018

Based on this idea.

Theme can define a list of pages it wants to render, and VuePress will render it during buliding.

I have wrote some docs along with the code in Chinese, please check it out in the code diff or here.

@meteorlxy
Copy link
Member

I'm waiting for #277 to be merged to add this feature

@meteorlxy
Copy link
Member

I don't think add the extra pages to options.siteData.pages is a good idea.

For example, if users want to v-for all the pages, they have to exclude the extra pages manually.

@ulivz
Copy link
Member

ulivz commented May 1, 2018

Thanks!

I think we should avoid opening new file-level API for new features. all of them should be transferred to plugin so that we can only focus on designing plugin API.

@ulivz ulivz closed this May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants