-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat($core): introduce vue meta to replace the current meta strategy fix #2153 #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@d-pollard is there any update on this? I have been playing around with Gridsome this past week because it is able to render content before hydration (interested mainly for SEO, etc.), and also already utilizes If this PR implements My use-case example is a blog setup where you want content available on the page for SEO (etc.) before hydration. |
@adamdehaven this is something I think would probably integrate fairly smoothly unless there are objections This PR probably needs a few reviewers (you could review if you'd like!) Will also want a few core team members to take a peak and see what they think |
@d-pollard I just started remodeling 2 bathrooms so my time is kinda scarce the next couple weeks outside of my regular job 😬 but if I have some time I'll definitely start reviewing 👍. I'm guessing the static site content pre-render (similar to Gridsome and Nuxt) would be a separate PR, so if that gets going, definitely tag me and I'll review that for SURE 🎉. I'm thinking that would be a setting that is configurable since I'm sure there are some that prefer the content to wait until after hydration. |
@adamdehaven - this should include the static site pre-render |
@d-pollard so I'm trying to run local in my project to test and I get Edit: Actually, it seems to be missing lots of dependencies (the next one is PostCSS) so I'm wondering if I'm running locally the wrong way? I followed the steps outlined here for local development |
@d-pollard ok, I'm not sure what I forgot to do the other day, but I was able to get this up and running in an existing project for an initial pass. Here's some feedback:
|
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
This feature introduces vue-meta in a way that is backwards compatible with our current meta strategy.
It also exposes
vueMeta
to frontmatter so you can directly use the API.Still a WIP