Skip to content

feat($theme-default): #1893 Clicking inline code select it #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adico1
Copy link
Contributor

@adico1 adico1 commented Oct 10, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome - Version 86.0.4240.75 (Official Build) (x86_64)
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@d-pollard d-pollard self-requested a review October 13, 2020 14:28
Copy link
Collaborator

@d-pollard d-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems like this doesn't have very good coverage, and no coverage in chrome outside of textboxes

source: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select

Would probably want a solution that works a bit better with chrome at least.

@adico1
Copy link
Contributor Author

adico1 commented Oct 13, 2020

hi @d-pollard, i didn't understood your request,

  1. do you want me to add css vendors for better support
  2. or you reject the idea and tell me to look for another solution?

if it's 2) can you please look at this conversation, they say 80% coverage is enough
and chrome does support user-select: all looking in MDN

please see the discussion in this issue:
#1893

Thanks

@d-pollard
Copy link
Collaborator

From MDN:

This doesn't have any effect on content loaded as chrome, except in textboxes.

I'm not outright rejecting this, but I would like to see full support, especially for Chrome since its market share is ~70%

@adico1
Copy link
Contributor Author

adico1 commented Oct 13, 2020

@d-pollard I tested this in chrome and clicking CODE once select the text with that style (it was also tested by the people in the reported issue).

I think the note in MDN is misleading.
scroll down to support and you'll see that chrome is supported.

user-select-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants