Skip to content

docs: Update default-theme-config.md #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Update default-theme-config.md #2645

wants to merge 1 commit into from

Conversation

wxsms
Copy link
Member

@wxsms wxsms commented Oct 5, 2020

Summary

Add one more desc to last update section.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@wxsms
Copy link
Member Author

wxsms commented Oct 5, 2020

I can also provide chinese version if anybody think that this is good and able to merge. thanks!

@wxsms wxsms changed the title Update default-theme-config.md doc: Update default-theme-config.md Oct 10, 2020
@d-pollard
Copy link
Collaborator

@wxsms - mind fixing the title and errors in the PR worflow? Once done, tag me and I'll review it :)

@wxsms wxsms changed the title doc: Update default-theme-config.md docs: Update default-theme-config.md Oct 14, 2020
@wxsms
Copy link
Member Author

wxsms commented Oct 14, 2020

@d-pollard Hello, I've just fix the workflow, pls have a look.

@d-pollard d-pollard self-requested a review October 15, 2020 18:23
Copy link
Collaborator

@d-pollard d-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-pollard d-pollard requested a review from bencodezen October 15, 2020 18:23
@wxsms
Copy link
Member Author

wxsms commented Oct 20, 2020

@bencodezen pls help give a look :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants